Add ability to debug dump input data only on errors #8970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
|
build |
abellina
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6964, #8672.
This changes the default semantics of the debug dump prefix configs to only dump the data on an exception. Dumping on every read is still possible by setting a new dumpAlways config to true, but it defaults to false. This is because for most situations, we're interested only in dumping the data that lead to a read error in libcudf.
This also updates the read exception to use the input splits specified for the read so the exception shows which files were trying to be read when the error occurred.