Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark reduction corner case tests as xfail on databricks until they can be fixed #899

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Mark reduction corner case tests as xfail on databricks until they can be fixed #899

merged 1 commit into from
Oct 1, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Oct 1, 2020

Just marks the tests as xfail pointing to the issue to fix them. This way we can avoid failed tests until next week when we can find time to fix the problem.

@revans2
Mark reduction corner case tests as xfail on databricks until they ca…
da5a3b2 
…n be fixed

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added this to the Sep 28 - Oct 9 milestone Oct 1, 2020
@revans2 revans2 self-assigned this Oct 1, 2020
@revans2 revans2 mentioned this pull request Oct 1, 2020
Closed
@revans2
Copy link
Collaborator Author

revans2 commented Oct 1, 2020

build

@revans2
Copy link
Collaborator Author

revans2 commented Oct 1, 2020

I verified that this fixes the issue for databricks. Oddly there are some tests passing on databricks that don't pass on the others.

XPASS src/main/python/hash_aggregate_test.py::test_generic_reductions[String] https://github.com/NVIDIA/spark-rapids/issues/898
XPASS src/main/python/hash_aggregate_test.py::test_distinct_float_count_reductions[Float] https://github.com/NVIDIA/spark-rapids/issues/837
XPASS src/main/python/hash_aggregate_test.py::test_distinct_float_count_reductions[Double] https://github.com/NVIDIA/spark-rapids/issues/837

Not a big deal but it would be nice to investigate it at some point.

@jlowe jlowe merged commit 1e1c4ca into NVIDIA:branch-0.3 Oct 1, 2020
@sameerz sameerz added the test Only impacts tests label Oct 5, 2020
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
@revans2 @sperlingxx
Mark reduction corner case tests as xfail on databricks until they ca…
c4076ba 
…n be fixed (NVIDIA#899)

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@revans2
Mark reduction corner case tests as xfail on databricks until they ca…
34c2d85 
…n be fixed (NVIDIA#899)

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@revans2
Mark reduction corner case tests as xfail on databricks until they ca…
b78839e 
…n be fixed (NVIDIA#899)

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Merge pull request NVIDIA#899 from NVIDIA/bot-auto-merge-branch-23.02
676acab 
[auto-merge] bot-auto-merge-branch-23.02 to branch-23.04 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@abellina abellina abellina approved these changes

@tgravescs tgravescs tgravescs approved these changes

@kuhushukla kuhushukla kuhushukla approved these changes

Assignees

@revans2 revans2

Labels
test Only impacts tests
Projects
None yet
Milestone
Sep 28 - Oct 9
Development

Successfully merging this pull request may close these issues.
6 participants
@revans2 @jlowe @abellina @tgravescs @kuhushukla @sameerz