Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert test changes to fix binary dedup error [databricks] #9006

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 11, 2023

Fixes #8962. Reverts #8977, #8744. Reopens #8712, #8713, #8714, #8715.

This reverts the changes that triggered the binary dedup error in order to unblock the 23.08 release. We will fix this in 23.10.

…ecutionPlanCaptureCallback.scala [databricks] (NVIDIA#8977)"

This reverts commit bcc929c.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
…arent struct array [databricks] (NVIDIA#8744)"

This reverts commit 1fb5fc4.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the build Related to CI / CD or cleanly building label Aug 11, 2023
@jlowe jlowe self-assigned this Aug 11, 2023
@jlowe
Copy link
Member Author

jlowe commented Aug 11, 2023

build

revans2
revans2 previously approved these changes Aug 11, 2023
@jlowe jlowe changed the base branch from branch-23.10 to branch-23.08 August 11, 2023 14:54
@jlowe jlowe dismissed revans2’s stale review August 11, 2023 14:54

The base branch was changed.

@jlowe
Copy link
Member Author

jlowe commented Aug 11, 2023

build

@jlowe jlowe changed the title Revert test changes to fix binary dedup error Revert test changes to fix binary dedup error [databricks] Aug 11, 2023
@jlowe
Copy link
Member Author

jlowe commented Aug 11, 2023

build

@razajafri razajafri merged commit 63a5a18 into NVIDIA:branch-23.08 Aug 11, 2023
28 checks passed
@jlowe jlowe deleted the revert-to-fix-dedup-error branch August 11, 2023 18:18
gerashegalov added a commit that referenced this pull request Aug 11, 2023
Fixes #9008

Testing:

- [x] reproduces #8962 
- [x] build.sh and test.sh on top of #9006 works

Signed-off-by: Gera Shegalov <gera@apache.org>
Co-authored-by: Gera Shegalov <gera@apach.org>
Co-authored-by: Thomas Graves <tgraves@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Nightly build failed: ExecutionPlanCaptureCallback$.class is not bitwise-identical across shims
4 participants