Add command-line argument for benchmark result filename #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
tgravescs
reviewed
Oct 2, 2020
| @@ -33,19 +33,21 @@ object TpcdsLikeBench extends Logging { | |||
| * @param spark The Spark session | |||
| * @param query The name of the query to run e.g. "q5" | |||
| * @param iterations The number of times to run the query. | |||
| * @param resultFilenameStub Optional name for the generated JSON summary file. | |||
There was a problem hiding this comment.
I'm assuming Stub here was intentional because I think its actually only part of the file name, we may want to clarify the description to say prefix for the...
There was a problem hiding this comment.
Thanks. I renamed to summaryFilePrefix to disambiguate from the output arguments that refer to the output of the query itself. I also updated the javadocs.
tgravescs
reviewed
Oct 2, 2020
| @@ -167,6 +179,7 @@ class Conf(arguments: Seq[String]) extends ScallopConf(arguments) { | |||
| val iterations = opt[Int](default = Some(3)) | |||
| val output = opt[String](required = false) | |||
| val outputFormat = opt[String](required = false) | |||
| val name = opt[String](required = false) | |||
There was a problem hiding this comment.
similar here, "name" ends up being the command line option perhaps we should be more specific like outputFilePrefix
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
tgravescs
approved these changes
Oct 2, 2020
|
Tests timed out. build. |
|
build |
Merged
|
build |
1 similar comment
|
build |
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
* Add command-line argument for benchmark result filename Signed-off-by: Andy Grove <andygrove@nvidia.com> * Rename parameter to summaryFilePrefix Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add command-line argument for benchmark result filename Signed-off-by: Andy Grove <andygrove@nvidia.com> * Rename parameter to summaryFilePrefix Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add command-line argument for benchmark result filename Signed-off-by: Andy Grove <andygrove@nvidia.com> * Rename parameter to summaryFilePrefix Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#904) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
When running automated benchmarks with a number of different configurations, it is important to be able to override the name of the generated report summary JSON file that contains the timing information.
This PR also updates the pom so that a
jar-with-dependenciesjar is built for theintegration_testmodule.