Revert "Implement SumUnboundedToUnboundedFixer (#8934)" #9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8927411. Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
revert-sum-unbounded
branch
from
6da7e65
to
57f5dd5
Compare
|
build |
revans2
approved these changes
Aug 17, 2023
revans2
reviewed
Aug 17, 2023
| } else { | ||
| DType.DTypeEnum.DECIMAL32.getNativeId | ||
| } | ||
| Scalar.fromNull(DType.fromNative(dt, d.scale)) |
There was a problem hiding this comment.
Just FYI I think this is the problem here. d.scale is a Spark scale, but DType wants -d.scale
abellina
approved these changes
Aug 17, 2023
sameerz
added
task
andygrove
added a commit
to andygrove/spark-rapids
that referenced
this pull request
Aug 22, 2023
…NVIDIA#9072)" This reverts commit 96f7153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9071
This reverts commit 8927411.
We are seeing the newly added integration test fail in some environments, so reverting the recent code change for now.