Add retry and SplitAndRetry support to AcceleratedColumnarToRowIterator #9088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
revans2
reviewed
Aug 22, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuColumnarToRowExec.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuColumnarToRowExec.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
revans2
approved these changes
Aug 23, 2023
| numOutputRows += cb.numRows() | ||
| if (cb.numRows() > 0) { | ||
| numOutputRows += scb.numRows() | ||
| if (scb.numRows() > 0) { |
There was a problem hiding this comment.
Sorry one more thing. If scb.numRows() <= 0 we probably should close it. Just to be on the safe side.
There was a problem hiding this comment.
Nice catch. I will do it in a follow-up PR soon.
sameerz
added
the
reliability
firestarman
added a commit
that referenced
this pull request
Aug 31, 2023
…#9102) This PR adds in retry support for more operations in GpuOutOfCoreSortIterator, including computing the split offset and bringing the data back to GPU to remove the projected columns. Besides, to keep being eager to close the input batches in the mergeSortAndClose function (introduced by #6931), instead of retrying the call to the whole mergeSortAndClose function, we retry the operations inside it, including bringing the data back to GPU, concatenating tables, sort the concatenated table and merging the input tables. It also covers a small followup change in GpuColumnToRowExec for PR #9088. --------- Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8348
This PR adds retry and
SplitAndRetrysupport toAcceleratedColumnarToRowIterator.It will retry converting columns to rows by cudf when getting any oom exception.