Instantiate execution plan capture callback via shim loader #9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
|
build |
jlowe
reviewed
Aug 25, 2023
...ain/spark311/scala/org/apache/spark/sql/rapids/ShimmedExecutionPlanCaptureCallbackImpl.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Aug 25, 2023
...ain/spark311/scala/org/apache/spark/sql/rapids/ShimmedExecutionPlanCaptureCallbackImpl.scala
Outdated
Show resolved
Hide resolved
|
build |
jlowe
previously approved these changes
Aug 25, 2023
|
build |
...gin/src/main/scala/org/apache/spark/sql/rapids/ShimmedExecutionPlanCaptureCallbackImpl.scala
Show resolved
Hide resolved
|
This should be ready to go in. If folks here don't mind to take a look @jlowe @gerashegalov @andygrove |
jlowe
approved these changes
Aug 25, 2023
abellina
deleted the
instantiate_ExecutionPlanCaptureCallback_via_ShimLoader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9103
This PR puts
ExecutionPlanCaptureCallbackunder the shims so it can use shimmed classes such asGpuFileSourceScanExec. I was able to repro the failure seen in the MT CI job locally and this approach fixes it.