-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support spark.sql.parquet.datetimeRebaseModeInWrite=LEGACY
#9132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
feature request
New feature or request
SQL
part of the SQL/Dataframe plugin
task
Work required that improves the product but is not user facing
labels
Aug 29, 2023
build |
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
build |
ttnghia
changed the title
Support
Support Sep 1, 2023
spark.sql.parquet.datetimeRebaseModeInWrite
spark.sql.parquet.datetimeRebaseModeInWrite=LEGACY
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
build |
sameerz
added
the
reliability
Features to improve reliability or bugs that severly impact the reliability of the plugin
label
Sep 2, 2023
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
revans2
reviewed
Sep 5, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetFileFormat.scala
Outdated
Show resolved
Hide resolved
revans2
reviewed
Sep 5, 2023
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
build |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
build |
revans2
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
New feature or request
reliability
Features to improve reliability or bugs that severly impact the reliability of the plugin
SQL
part of the SQL/Dataframe plugin
task
Work required that improves the product but is not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
LEGACY
mode inspark.sql.parquet.datetimeRebaseModeInWrite
, which allows writing ancient dates/times before1582-10-15
with rebasing from Proleptic Gregorian calendar dates/times to Julian calendar dates/times.Closes:
Depends on: