Improve some CSV integration tests [databricks] #9146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
added
task
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
gerashegalov
previously approved these changes
Sep 6, 2023
Comment on lines
555
to
556
| # TODO this does not confirm that this scan actually runs on GPU, but I am not | ||
| # sure if we can capture the plan with a COUNT, since it normally requires a COLLECT |
There was a problem hiding this comment.
let us file an issue and maybe reference it in the comment
There was a problem hiding this comment.
Thanks @gerashegalov . I have filed #9199 and updated the comment.
|
build |
revans2
approved these changes
Sep 27, 2023
gerashegalov
approved these changes
Sep 27, 2023
| lambda spark : spark.read.schema(gen.data_type)\ | ||
| .csv(data_path)\ | ||
| .filter(f.col('a') > 0)\ | ||
| .selectExpr('a', | ||
| 'input_file_name()', | ||
| 'input_file_block_start()', | ||
| 'input_file_block_length()'), | ||
| cpu_fallback_class_name = 'FileSourceScanExec' if v1_enabled_list == 'csv' else 'BatchScanExec', |
There was a problem hiding this comment.
not a must-fix, stylistically and because in a future the parameter v1_enabled_list might become a comma-separated value or a Python list we might want to check for 'csv' in v1_enabled_list rather than equality.
razajafri
approved these changes
Sep 27, 2023
andygrove
changed the title
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the CSV integration tests need to allow some operators to fallback because, in some cases, the CPU scans the file before the GPU does (such as when inferring the schema). However, these tests were then invoking
assert_gpu_and_cpu_are_equal_collectwithout verifying that anything ran on the GPU, meaning that the tests were not really testing what they needed to, and regressions could go undetected.This PR aims to address that by calling
assert_cpu_and_gpu_are_equal_collect_with_captureinstead, and confirming that the expected operator ran on the GPU.