Support Retry for GpuLocalLimitExec and GpuGlobalLimitExec #9193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
revans2
previously approved these changes
Sep 6, 2023
| } | ||
| } | ||
|
|
||
| def apply( |
There was a problem hiding this comment.
nit: could we call this something different. To me GpuBaseLimitExec.apply should return a GpuBaseLimitExec, we are not 100% consistent about that. Could we rename the object to GpuBaseLimitExecIterator? It would make it a little clearer.
There was a problem hiding this comment.
Updated. I changed the new object "GpuBaseLimitExec" to a class called GpuBaseLimitIterator .
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
res-life
approved these changes
Sep 7, 2023
sameerz
added
the
reliability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8315
This PR adds the retry support to the processing of slicing the batch (in
sliceBatchAndCloseWithRetryfunction) used by bothGpuLocalLimitExecandGpuGlobalLimitExec.It also does some refactor by moving the code of the output iterator to a new iterator named
GpuBaseLimitIterator, then we can test the core logic by unit tests.