Fix a few minor things with scale test #9200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
razajafri
reviewed
Sep 7, 2023
| @@ -73,6 +72,32 @@ class QuerySpecs(config: Config, spark: SparkSession) { | |||
| numericColumns | |||
| } | |||
|
|
|||
| /** | |||
| * To get columns in a dataframe that work with min/max. | |||
| * Now numeric columns are limited to [byte, int, long, decimal, string] | |||
There was a problem hiding this comment.
docs missing TimestampType and DateType
gerashegalov
reviewed
Sep 8, 2023
Comment on lines
90
to
97
| df.dtypes.filter { | ||
| case (_, dataType) => | ||
| dataType == "ByteType" || dataType == "IntegerType" || dataType == "LongType" || | ||
| dataType.startsWith("DecimalType") || dataType == "StringType" || | ||
| dataType == "TimestampType" || dataType == "DateType" | ||
| }.map { | ||
| case (columnName, _) => columnName | ||
| } |
There was a problem hiding this comment.
nit: consider pattern matching for readability
val decimalTypePrefixRegex = "^DecimalType.*".r
df.dtypes.collect {
case (columnName, "ByteType") => columnName
case (columnName, "IntegerType") => columnName
...
case (columnName, decimalTypePrefixRegex) => columnName
}
|
build |
gerashegalov
approved these changes
Sep 8, 2023
Comment on lines
+60
to
+64
| df.schema.map { field => | ||
| (field.name, field.dataType) | ||
| }.collect { | ||
| case (columnName, ByteType | IntegerType | LongType | _: DecimalType) => | ||
| columnName |
There was a problem hiding this comment.
no need to fix, just a remark that even with this improvement map is not really necessary (unless it causes issues with different Spark versions) if we collect with
case StructField(columnName, ByteType | IntegerType | LongType | _: DecimalType, _, _) => columnName
|
@wjxiz1992 could you take a look too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9198
It also