Simplified handling of GPU core dumps #9238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
sameerz
added
the
task
revans2
previously approved these changes
Sep 19, 2023
|
build |
gerashegalov
reviewed
Oct 2, 2023
revans2
previously approved these changes
Oct 2, 2023
tgravescs
reviewed
Oct 3, 2023
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
revans2
previously approved these changes
Oct 3, 2023
gerashegalov
previously approved these changes
Oct 3, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCoreDumpHandler.scala
Show resolved
Hide resolved
tgravescs
previously approved these changes
Oct 3, 2023
jlowe
dismissed stale reviews from tgravescs, gerashegalov, and revans2
via
b4aeffd
|
build |
gerashegalov
approved these changes
Oct 3, 2023
revans2
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configs for simplified GPU core dump handling. This approach creates a named pipe and listens to the pipe with a background thread to copy the GPU core file to a path that is built with the configured coredump URI prefix. Coredumps can be configured as lightweight or full, and are by default compressed with zstd before uploading to the (potentially remote) filesystem.