Benchmark guide update for command-line interface / spark-submit #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
benchmark-guide-updates
branch
from
75cadac
to
b652a7b
Compare
|
build |
jlowe
previously approved these changes
Oct 9, 2020
sameerz
reviewed
Oct 10, 2020
|
build |
|
build |
jlowe
previously approved these changes
Oct 12, 2020
andygrove
commented
Oct 12, 2020
docs/benchmarks.md
Outdated
|
|
||
| The benchmarks can be executed in two modes currently: | ||
|
|
||
| - Execute the query and collect the results to the driver | ||
| - Execute the query and write the results to disk (in Parquet or CSV format) | ||
| - Execute the query and write the results to disk (in Parquet or ORC format) |
There was a problem hiding this comment.
So, this wasn't an error after all. The benchmarks do currently support writing. to Parquet and CSV only. I will add ORC support as part of this PR.
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
reviewed
Oct 12, 2020
integration_tests/src/main/scala/com/nvidia/spark/rapids/tests/common/BenchUtils.scala
Show resolved
Hide resolved
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
approved these changes
Oct 12, 2020
|
build |
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
…DIA#924) * Add spark-submit usage Signed-off-by: Andy Grove <andygrove@nvidia.com> * Update docs/benchmarks.md * Add option to write to ORC Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add match for WriteOrc Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add match for Orc when writing results summary file Signed-off-by: Andy Grove <andygrove@nvidia.com> Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…DIA#924) * Add spark-submit usage Signed-off-by: Andy Grove <andygrove@nvidia.com> * Update docs/benchmarks.md * Add option to write to ORC Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add match for WriteOrc Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add match for Orc when writing results summary file Signed-off-by: Andy Grove <andygrove@nvidia.com> Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…DIA#924) * Add spark-submit usage Signed-off-by: Andy Grove <andygrove@nvidia.com> * Update docs/benchmarks.md * Add option to write to ORC Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add match for WriteOrc Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add match for Orc when writing results summary file Signed-off-by: Andy Grove <andygrove@nvidia.com> Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-23.02 to branch-23.04 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of small errors in the guide and adds instructions on using spark-submit to run benchmarks.