Allow checkpoint and restore on non-deterministic expressions in GpuFilter and GpuProject #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
revans2
previously approved these changes
Sep 25, 2023
| package com.nvidia.spark; | ||
|
|
||
| /** | ||
| * An interface that can be used by Retry framework of RAPIDS Plugin to handle the GPU OOMs. |
There was a problem hiding this comment.
I think this is too much detail for an end user. Could we adjust it a bit? Perhaps something more like.
An interface that can be used to retry the processing on non-deterministic expressions on the GPU.
GPU memory is a limited resource. When it runs out the RAPIDS Accelerator for Apache Spark will
use several different strategies to try and free more GPU so the query can complete. One of these
strategies is to roll back the processioning for one task, pause that tasks thread, than then retry
the task when more memory is available. This works transparently for any stateless deterministic
processing. But technically an expression/UDF can be non-deterministic and/or keep state in
between calls. This interface provides a checkpoint method to save any needed state, and a
restore method to reset the state in the case of a retry. Please note that a retry is not isolated to
a single expression, so a restore can be called even after the expression returned
one or more batches of results.
Each time checkpoint it called any previously saved state can be overwritten.
| */ | ||
| public interface Retryable { | ||
| /** | ||
| * Save the state, so it can be restored in case of an OOM Retry. |
There was a problem hiding this comment.
nit: can we drop the OOM here?
Save the state so it can be restored in the case of a retry.
sameerz
added
the
reliability
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7865
This PR is to support
checkpointandrestoreon non-deterministic expressions inGpuFilterandGpuProject.Retryablein Java to supprt Java UDF in the future for end users. A non-deterministic expression can implement this interface to make it retryable.RapidsXORShiftRandomto provide access to the internal hashed seed. This is used byGpuRandto implement theRetryableinterface.CheckpointRestoretrait, replaced by the newRetryableinterface.GpuRandto supportcheckpointandrestore.GpuExpression, they areselfNonDeterministicandretryable.retryableis used to tell whether an expression is retryable. It will cover its children. WhileselfNonDeterministicindicates whether an expression itself is non-deterministic when its "deterministic" is false, excluding its children. An expression is actually a tree, anddeterministicbeing false means there is at least one tree node is non-deterministic, but we need to know the exact nodes which are non-deterministic to check if it implements theRetryable. SoselfNonDeterministicis created.TODO