Initiate arm64 CI support [skip ci] #9308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxLi
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
force-pushed
the
add-arm-CI-support
branch
from
0a3f47e
to
de1a6d2
Compare
pxLi
added
documentation
|
build |
jlowe
reviewed
Sep 27, 2023
jenkins/Dockerfile-blossom.multi
Outdated
Comment on lines
69
to
70
| # export JAVA_HOME for mvn option 'source-javadoc' | ||
| ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-${ARCH} |
There was a problem hiding this comment.
Nit This should be near the line that updates the Java alternatives so it's easier to keep the two in sync.
|
build |
NvTimLiu
approved these changes
Sep 28, 2023
firestarman
reviewed
Sep 28, 2023
| ARG UCX_VER=1.15.0-rc6 | ||
| # multi-platform build with: docker buildx build --platform linux/arm64,linux/amd64 <ARGS> on either amd64 or arm64 host | ||
| # check available official arm-based docker images at https://hub.docker.com/r/nvidia/cuda/tags (OS/ARCH) | ||
| FROM --platform=$TARGETPLATFORM nvidia/cuda:${CUDA_VER}-runtime-ubuntu${UBUNTU_VER} |
There was a problem hiding this comment.
Where is to define TARGETPLATFORM ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #9274
In this change we,
ARCH default as arm64, CUDA default as 11.8.0 (depends on arm support of official cuda images in dockerhub)
All changes have been verified in CI (the image has been used in nightly already) and local ENVs