Update first/last tests to avoid non-determinisim and ordering differences #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ences Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
tgravescs
reviewed
Oct 13, 2020
| @@ -134,6 +146,8 @@ def idfn(val): | |||
| 'spark.rapids.sql.hasNans': 'false', | |||
| 'spark.rapids.sql.castStringToFloat.enabled': 'true', | |||
| 'spark.rapids.sql.castFloatToString.enabled': 'true', | |||
| # some of the first/last tests need a single partition to work reliably when run on a large cluster. | |||
| 'spark.sql.shuffle.partitions': '1' | |||
There was a problem hiding this comment.
would it be better to split the first/last test to use different confs so we can test others with multiple partitions?
There was a problem hiding this comment.
Sure simple enough to do.
|
build |
tgravescs
approved these changes
Oct 13, 2020
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
…ences (NVIDIA#933) Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…ences (NVIDIA#933) Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…ences (NVIDIA#933) Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#933) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the majority of #812 but it does not fix all of the issues. I'll try to address them in separate PRs as I debug them further.