Update MULTITHREADED shuffle maxBytesInFlight default to 128MB #9344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
revans2
approved these changes
Sep 29, 2023
tgravescs
approved these changes
Sep 29, 2023
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9153
This updates the default value of spark.rapids.shuffle.multiThreaded.maxBytesInFlight to 128MB given a netty OOM I saw here #9153, and after testing different maxBytesInFlight values. There will be follow ups to this as we work to really limit host memory usage, but this is certainly a more conservative default than the 2GB that it is set to now.