Fix auto merge conflict 9372 #9373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvidia… (NVIDIA#9362) * Removing User Guide pages that will be source of truth on docs.nvidia.com Signed-off-by: mattahrens <matthewahrens@gmail.com> * Updating links in README to point to docs.nvidia.com User Guide Signed-off-by: mattahrens <matthewahrens@gmail.com> * Fixing broken links in other pages for User Guide updates Signed-off-by: mattahrens <matthewahrens@gmail.com> * Fixing broken links in supported ops page Signed-off-by: mattahrens <matthewahrens@gmail.com> * Updating TypeChecks to keep in line with supported_ops.md Signed-off-by: mattahrens <matthewahrens@gmail.com> --------- Signed-off-by: mattahrens <matthewahrens@gmail.com>
Signed-off-by: mattahrens <matthewahrens@gmail.com>
|
build |
jlowe
approved these changes
Oct 3, 2023
razajafri
approved these changes
Oct 4, 2023
Yes, it's because of the code changes. Yes, arguably one could say the git workflow checks that just compile but don't run any tests are sufficient for this change, but that becomes a slippery slope if people start deciding to skip CI even with code changes because they're convinced it won't matter. It wasn't critical to get this in ASAP, so IMO running through CI was fine. |
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not squash commits