Fix parsing of Parquet legacy list-of-struct format #9380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
the
cudf_dependency
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
force-pushed
the
fix-parquet-repeated-no-annotation
branch
from
3a0a595
to
0cacc00
Compare
revans2
approved these changes
Oct 4, 2023
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8631. Depends on rapidsai/cudf#13715 and NVIDIA/spark-rapids-jni#1475.
Schema checking was not properly handling the legacy array-of-struct encoding where the list can contain more than one child. Updated the logic to handle that case which, along with the corresponding fixes from cudf and spark-rapids-jni, allows the repeated_no_annotation.parquet file to be properly decoded.