Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix docker modified check in premerge [skip ci] #9415

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[BUG] fix docker modified check in premerge [skip ci] #9415

merged 1 commit into from
Oct 10, 2023

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Oct 10, 2023

first found in #9366

The jenkins shell suddenly does not support using $(cmd) to generate value.
Change it to use """ wrapper to solve the issue

verified in #9413

@pxLi pxLi added bug Something isn't working build Related to CI / CD or cleanly building labels Oct 10, 2023
@pxLi
Copy link
Collaborator Author

pxLi commented Oct 10, 2023

build

@pxLi
fix docker modified check in premerge
5bd8794 
Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi pxLi force-pushed the fix-premerge-docker-detector branch from e3d64c7 to 5bd8794 Compare October 10, 2023 08:32
@pxLi pxLi merged commit 28aba18 into NVIDIA:branch-23.10 Oct 10, 2023
27 of 29 checks passed
@pxLi pxLi mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanxuanLiu YanxuanLiu YanxuanLiu approved these changes

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@zhanga5 zhanga5 Awaiting requested review from zhanga5

Assignees
No one assigned
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxLi @YanxuanLiu