Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Split And Retry for GpuProjectAstExec #9527

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

winningsix
Copy link
Collaborator

This is to support split & retry for GpuProjectAstExec. It's tracked in 8311.

Tested by newly added UTs locally.

Signed-off-by: Ferdinand Xu <ferdinandx@nvidia.com>
@winningsix
Copy link
Collaborator Author

build

revans2
revans2 previously approved these changes Oct 24, 2023
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits

jlowe
jlowe previously approved these changes Oct 24, 2023
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise lgtm.

@sameerz sameerz added the reliability Features to improve reliability or bugs that severly impact the reliability of the plugin label Oct 24, 2023
@winningsix winningsix dismissed stale reviews from jlowe and revans2 via fc8e542 October 26, 2023 09:09
@winningsix
Copy link
Collaborator Author

build

@revans2 revans2 merged commit 1177b8f into NVIDIA:branch-23.12 Oct 26, 2023
29 of 30 checks passed
@winningsix winningsix deleted the ast branch October 26, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants