Fix tiered project breaking higher order functions #9538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
gerashegalov
approved these changes
Oct 25, 2023
revans2
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where tiered project can break the evaluation of higher order functions by combining lambda functions that cannot be evaluated in isolation, separate from the context of the higher-order function being evaluated. This eventually triggers an attempt to evaluate an unevaluable lambda variable and crashes the query.
addExprTreetries to avoid this, but is checking for the CPU version of lambda variables rather than the GPU version. That logic has been removed since it's ineffective in practice. GpuLambdaFunction was updated to overridedisableTieredProjectCombineso its expression tree will never be combined with others.