Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Ignore failing Parquet filter test to unblock CI (#9519)" #9594

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Revert "Ignore failing Parquet filter test to unblock CI (#9519)" #9594

merged 2 commits into from
Nov 1, 2023

Conversation

sameerz
Copy link
Collaborator

@sameerz sameerz commented Nov 1, 2023

Issue rapidsai/cudf#14315 is closed with PR rapidsai/cudf#14322

This PR adds back tests for "Parquet filter pushdown - timestamp" by reverting commit eeb4168.

Closes #9507

@sameerz sameerz added the test Only impacts tests label Nov 1, 2023
@sameerz
Revert "Ignore failing Parquet filter test to unblock CI (NVIDIA#9519)"
7918839 
This reverts commit eeb4168.

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz
Merge branch 'branch-23.12' of https://github.com/nvidia/spark-rapids …
9dc43d5 
…into branch-23.12

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz
Copy link
Collaborator Author

sameerz commented Nov 1, 2023

build

gerashegalov
gerashegalov approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jlowe
jlowe approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed because the re-enabled test failed. The cudf change had not yet been propagated to the spark-rapids-jni snapshot. It should be there now after last night's build.

@jlowe
Copy link
Member

jlowe commented Nov 1, 2023

build

@sameerz sameerz merged commit 084a7c0 into NVIDIA:branch-23.12 Nov 1, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

Assignees

@sameerz sameerz

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Spark 3.2+/ParquetFilterSuite/Parquet filter pushdown - timestamp/ FAILED
3 participants
@sameerz @jlowe @gerashegalov