Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Support For Various Execs for Databricks 13.3 #9637

Merged
merged 16 commits into from
Nov 7, 2023
Merged

Added Support For Various Execs for Databricks 13.3 #9637

merged 16 commits into from
Nov 7, 2023

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Nov 6, 2023 •
edited
Loading

This pull request introduces essential changes for adding compatibility for Databricks 13.3, specifically focusing on refactoring existing shims.

Changes Made:

  • Extracted a base class from GpuShuffleExchangeExec so the behavior can be shared between Spark versions
  • ParquetCVShims is now using getExistenceDefaultValues method instead of existenceDefaultValues array as it has been converted to an Option in the new Databricks version.
  • Fixes test_multi_table_hash_join test failure
  • Other changes to add support where needed like adding shims or changing method calls

Testing

Tests will be added in future PR

fixes #9491
contributes towards 9175

@sameerz sameerz added the task Work required that improves the product but is not user facing label Nov 6, 2023
@razajafri razajafri mentioned this pull request Nov 6, 2023
Closed
@razajafri razajafri marked this pull request as ready for review November 6, 2023 18:03
jlowe
jlowe reviewed Nov 6, 2023
View reviewed changes
...gin/src/main/spark321db/scala/org/apache/spark/rapids/shims/GpuShuffleExchangeExecBase.scala Outdated Show resolved Hide resolved
...lugin/src/main/spark341db/scala/com/nvidia/spark/rapids/shims/PartitionedFileUtilsShim.scala Outdated Show resolved Hide resolved
sql-plugin/src/main/spark341db/scala/org/apache/spark/rapids/shims/GpuShuffleExchangeExec.scala Outdated Show resolved Hide resolved
...ugin/src/main/spark341db/scala/org/apache/spark/sql/hive/rapids/shims/FileSinkDescShim.scala Outdated Show resolved Hide resolved
...in/src/main/spark341db/scala/org/apache/spark/sql/hive/rapids/shims/HiveInspectorsShim.scala Outdated Show resolved Hide resolved
...c/main/spark341db/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastHashJoinExec.scala Outdated Show resolved Hide resolved
@jlowe
Copy link
Member

jlowe commented Nov 6, 2023

build

1 similar comment
@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri merged commit 40d2647 into NVIDIA:branch-23.12 Nov 7, 2023
37 checks passed
@razajafri razajafri deleted the db13.3-new branch November 7, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Failing Test test_multi_table_hash_join for Databricks 13.3
3 participants
@razajafri @jlowe @sameerz