Update verify check to handle new pom files [skip ci] #9657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVnavkumar
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
pxLi
as code owners
|
build |
Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
jlowe
approved these changes
Nov 8, 2023
Comment on lines
+167
to
+168
| if [ -n "$(echo -n $(git status -s | grep 'scala2.13'))" ]; then | ||
| git add -N scala2.13/* && git diff 'scala2.13/*' |
There was a problem hiding this comment.
Suggested change
| if [ -n "$(echo -n $(git status -s | grep 'scala2.13'))" ]; then | |
| git add -N scala2.13/* && git diff 'scala2.13/*' | |
| if [[ -n $(git status --porcelain scala2.13) ]]; then | |
| git add -N scala2.13 && git diff scala2.13 |
gerashegalov
changed the title
gerashegalov
reviewed
Nov 8, 2023
| @@ -164,7 +164,8 @@ jobs: | |||
| # verify Scala 2.13 build files | |||
| ./build/make-scala-version-build-files.sh 2.13 | |||
| # verify git status | |||
| if ! git diff --exit-code 'scala2.13/*'; then | |||
| if [ -n "$(echo -n $(git status -s | grep 'scala2.13'))" ]; then | |||
| git add -N scala2.13/* && git diff 'scala2.13/*' | |||
There was a problem hiding this comment.
nit: * is unnecessary for git add
As a more compact fix we could just insert before L167 in the current code
git add -N scala2.13
which will be a NOP if there are no untracked files without changing anything else
Changes to this file don't affect the internal CI so adding [skip ci] to the PR title to save resources.
sameerz
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9650.
This updates the github workflow check to properly check for newer build files that needed to be added for Scala 2.13 and shows the diff properly for those files and any changed files.