Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support split non-AST-able join condition for BroadcastNested… [databricks] #9695

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

winningsix
Copy link
Collaborator

…LoopJoin (#9635)"

This reverts commit c20a843. which breaks databricks branch.

@winningsix winningsix changed the title Revert "Support split non-AST-able join condition for BroadcastNested… Revert "Support split non-AST-able join condition for BroadcastNested… [databricks] Nov 14, 2023
@winningsix
Copy link
Collaborator Author

build

…LoopJoin (NVIDIA#9635)"

This reverts commit c20a843.

Signed-off-by: Ferdinand Xu <ferdinandx@nvidia.com>
@winningsix
Copy link
Collaborator Author

build

@winningsix
Copy link
Collaborator Author

cc @pxLi

@pxLi pxLi added the bug Something isn't working label Nov 14, 2023
Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Lets wait for the pre-merge CI

@pxLi pxLi added test Only impacts tests build Related to CI / CD or cleanly building labels Nov 14, 2023
@winningsix
Copy link
Collaborator Author

I got a hot fix #9696. Let's wait for it before reverting this.

@winningsix winningsix merged commit 56de325 into NVIDIA:branch-23.12 Nov 14, 2023
37 checks passed
@winningsix winningsix deleted the revert branch November 14, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants