Check paths for existence to prevent ignorable error messages during build #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#9782 Use `-Dnonfail.errors.quiet=false` when debugging Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
pxLi
as code owners
jlowe
changed the title
jlowe
reviewed
Nov 20, 2023
aggregator/pom.xml
Outdated
Comment on lines
163
to
164
| discardOutput="${nonfail.errors.quiet}" | ||
| discardError="${nonfail.errors.quiet}"> |
There was a problem hiding this comment.
Rather than suppress errors by default, does it make more sense to make this execution conditional on old class dir existing or some other check that indicates this is not a clean build?
gerashegalov
changed the title
|
build |
1 similar comment
|
build |
|
build |
|
@jlowe please take a look when you get a chance |
jlowe
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9782
Signed-off-by: Gera Shegalov gera@apache.org