Add support for decimal in to_json
#9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
to_jsonto_json
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
to_jsonto_json
|
build |
revans2
previously approved these changes
Nov 28, 2023
| @@ -3600,8 +3600,10 @@ object GpuOverrides extends Logging { | |||
| TypeSig.STRING, | |||
| Seq(ParamCheck("struct", | |||
| (TypeSig.BOOLEAN + TypeSig.STRING + TypeSig.integral + TypeSig.FLOAT + | |||
| TypeSig.DECIMAL_64 + TypeSig.DECIMAL_128 + | |||
There was a problem hiding this comment.
DECIMAL_128 implied DECIMAL_64 so it is redundant to have both here.
There was a problem hiding this comment.
I have removed DECIMAL_64
|
build |
revans2
previously approved these changes
Nov 29, 2023
|
build |
revans2
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9872