Fix zero-scale floor and ceil tests #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
This was
linked to
issues
Nov 28, 2023
|
build |
revans2
approved these changes
Nov 28, 2023
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9722 and #9846. Floor and ceiling operations that take a specified scale do not take floating point operations as inputs, so Spark is implicitly casting the floating point inputs to decimal types before the operation. Casting of floating point to decimal types is a known, documented limitation, and it's disabled by default. Since these tests are not trying to test casting from floating point to decimal tests but rather just the floor and ceiling operations with a specified scale, the tests were updated to not test floating point inputs since those are known to not match Spark because of the implicit cast to decimal.