Fix test_cast_string_ts_valid_format test #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
revans2
approved these changes
Nov 29, 2023
|
build |
1 similar comment
|
build |
|
should this be targeted to 23.12 or 24.02? |
|
Since it's just a test code change and doesn't block the 23.12, I think it should be ok to 24.02. |
cool, also updated the corresponding issue ticket to 24.02 |
ttnghia
added a commit
to ttnghia/spark-rapids
that referenced
this pull request
Dec 1, 2023
This reverts commit 7c653bf.
ttnghia
added a commit
to ttnghia/spark-rapids
that referenced
this pull request
Dec 1, 2023
…"" This reverts commit 688f899.
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9708
In case of failure:
StringGen('[0-9]{1,4}-[0-3][0-9]-[0-5][0-9][ |T][0-3][0-9]:[0-6][0-9]:[0-6][0-9].[0-9]{0,6}Z?')The
.here is meant to be a literal., but it's a wildcard character in regex, so it can generate anything in this case, which also leads to many invalid timestamps.In the failed case it generated '+':
7141-09-13 08:15:02+121024and Spark supports this format but we do not yet.This PR replaces the
.with\.to fix the test.