Fix Java OOM caused by incorrect state of shouldCapture when exception occurred #9944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Xu <ferdinandx@nvidia.com>
|
build |
jlowe
approved these changes
Dec 4, 2023
revans2
approved these changes
Dec 4, 2023
res-life
pushed a commit
to res-life/spark-rapids
that referenced
this pull request
Dec 11, 2023
Signed-off-by: Ferdinand Xu <ferdinandx@nvidia.com>
pxLi
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #9829.
Typically,
shouldCaptureinShimmedExecutionPlanCaptureCallbackImplshould work as pair ofstartCaptureandgetResultsWithTimeout. But it may fail to be restored when exception happens in Gpu run sesssion. In #9829 case, it missed to add a non-GPU operator resulting in anIllegalArgumentException. ThengetResultsWithTimeoutwas failed to be updated.