Override the seed for test_map_scalars_supported_key_types for version of Spark before 3.4.0 [Databricks]
#9949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
|
it would be nice to have the title and description mention this is only overriding in the test_map_scalars_supported_key_types test |
tgravescs
reviewed
Dec 4, 2023
razajafri
changed the title
test_map_scalars_supported_key_types for version of Spark before 3.4.0 [Databricks]
|
build |
tgravescs
previously approved these changes
Dec 5, 2023
jlowe
reviewed
Dec 5, 2023
jlowe
approved these changes
Dec 5, 2023
|
build |
revans2
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
conditionparameter based on which we should override thedatagen_overridesif it's provided. If no condition is provided then we apply the override unconditionally.Based on the findings, the bug stems from an old bug in Spark decimal sort.
fixes #9683