Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark automation script #998

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Oct 21, 2020

Signed-off-by: Andy Grove andygrove@nvidia.com

The Python script for running automated benchmarks needs updating due to the recent refactor to the Scala code.

I also addressed some inconsistencies around default arguments.

…the benchmark runner

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove added the benchmark Benchmarking, benchmarking tools label Oct 21, 2020
@andygrove andygrove added this to the Oct 12 - Oct 23 milestone Oct 21, 2020
@andygrove andygrove self-assigned this Oct 21, 2020
@abellina
Copy link
Collaborator

For --output and --output-format I noticed these are marked as required in the options but are documented otherwise, that was a small fix I had to do locally. Not related to this PR specifically, but while you are here.

@andygrove andygrove changed the title [WIP] Update benchmark automation script Update benchmark automation script Oct 21, 2020
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Copy link
Contributor Author

build

@jlowe jlowe merged commit e387e99 into NVIDIA:branch-0.3 Oct 21, 2020
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
* Update benchmark automation script to reflect the recent refactor to the benchmark runner

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* Fix some inconsistencies around argument defaults

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove deleted the update-benchmark-py branch December 17, 2020 15:26
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Update benchmark automation script to reflect the recent refactor to the benchmark runner

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* Fix some inconsistencies around argument defaults

Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Update benchmark automation script to reflect the recent refactor to the benchmark runner

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* Fix some inconsistencies around argument defaults

Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#998)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Benchmarking, benchmarking tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants