Added possibility to suppress or throw exceptions during config loading

[peterdeme]

Hi Guys,

So we are getting serious troubles becauses of this.. Actually I don't really understand why is it good to suppress config loading error, but its fine I made it true by default.

Thanks
Peter

[adamhathcock]

The suppression of errors was in the original python: https://github.com/fugue/credstash/blob/master/credstash.py#L343
I recall there were valid errors because of dynamo querying and ignoring was safe because the value just wouldn't be in the list.

I'm not sure what issues you're seeing.

Also, if you were going to do this, you should put the option on the options class provided.

[peterdeme]

"I'm not sure what issues you're seeing."

Well, lacking permission of reading from table, decrypting with key etc.
The original code is bad as well, valid errors must be allowed explicitly, but this implementation suppresses literally every error which is dangerous.

"Also, if you were going to do this, you should put the option on the options class provided."

Okay.

[peterdeme]

Is this fine by you in the current state @adamhathcock ?

[adamhathcock]

Sorry. I forgot about this.

Do you mind bumping the minor version like this?: https://github.com/Narochno/Narochno.Credstash/pull/14/files

[peterdeme]

Sure, bumped minor to 2.2.0