Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend credstash - Added 'GetAllAsync' and 'PutAsync' methods to credstash class #18

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Extend credstash - Added 'GetAllAsync' and 'PutAsync' methods to credstash class #18

merged 2 commits into from
Mar 23, 2018

Conversation

germrfy
Copy link
Contributor

@germrfy germrfy commented Mar 22, 2018

  • Added new methods to ICredstash interface
  • Added an optional 'expires' to dynamodb credstash items for use in 'TTL' scenarios

@germrfy @fcallejon
Extend credstash - Added 'GetAllAsync' and 'PutAsync' to credstash cl…
a91869f 
…ass (#1)

* WIP - inital commit

* WIP - small refactor

* WIP - remove needless const

* WIP - add configure await

* Added new methods to ICredstash interface

* missed a configureAwait

* Added an optional 'expires' to dynamodb credstash items for use in 'TTL' scenarios

* CR - Feedback
@germrfy
Copy link
Contributor Author

germrfy commented Mar 22, 2018

Hi,

I needed to implement the 'Put' and 'GetAll' methods from the original credstash library for a project I am working on.

I also added the ability to optionally specify an 'expires' time when writing secrets to DynamoDB which is useful if you want to add a TTL to the table.

Thanks,

Ger

@adamhathcock
Copy link
Member

Do you mind incrementing the minor version of the library?

@germrfy
Copy link
Contributor Author

germrfy commented Mar 22, 2018

No problem, bumped the version to 2.3.0

@adamhathcock adamhathcock merged commit 3603f13 into Narochno:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhathcock adamhathcock adamhathcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germrfy @adamhathcock