forked from angular/angular.js
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix($animate): correctly access minErr
ngMinErr is not available in the build, but it is available during unit tests. The added tests don't actually catch this error, they have just been added for completeness.
- Loading branch information
Showing
2 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1408,7 +1408,24 @@ describe("animations", function() { | |
}); | ||
})); | ||
|
||
it('should allow an element to pinned elsewhere and still be available in animations', | ||
it('should complain if the arguments are not elements', | ||
inject(function($animate, $compile, $document, $rootScope, $rootElement) { | ||
|
||
var element = jqLite('<div></div>'); | ||
|
||
expect(function() { | ||
$animate.pin(element); | ||
}).toThrow(); | ||
This comment has been minimized.
Sorry, something went wrong.
matsko
|
||
|
||
expect(function() { | ||
$animate.pin(null, $rootElement); | ||
}).toThrow(); | ||
This comment has been minimized.
Sorry, something went wrong.
matsko
|
||
|
||
dealoc(element); | ||
})); | ||
|
||
|
||
it('should allow an element to be pinned elsewhere and still be available in animations', | ||
inject(function($animate, $compile, $document, $rootElement, $rootScope) { | ||
|
||
var innerParent = jqLite('<div></div>'); | ||
|
Oops how did I miss that one.