Remove Poetry cache from Docker image #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next round of installation uses the lock file, so cache is unnecessary
|
Kudos, SonarCloud Quality Gate passed!
|
juhoinkinen
changed the title
Codecov ReportBase: 99.61% // Head: 99.61% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 87 87
Lines 6038 6038
=======================================
Hits 6015 6015
Misses 23 23 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to use Poetry in Dockerfile (#605) increased the Docker image size to 3.2 GB. The image size for Annif v0.58 is 1.92 GB.
Simple fix is to just delete the cache after the installation (the
--no-cacheoption of Poetry had no effect). The dependency resolution creates thepoetry.lockfile, which is used on the second round of installation (after adding Annif source code), so cache is unnecessary.