errorprone :: MethodCanBeStatic (#977)

NationalSecurityAgency · Oct 18, 2024 · 050a924 · 050a924
1 parent e526ef4
commit 050a924
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/emissary/admin/Startup.java b/src/main/java/emissary/admin/Startup.java
@@ -521,7 +521,7 @@ protected void sortPlaces(final List<String> placeList) {
         }
     }
 
-    private void sortPickupOrPlace(String theLocation, Map<String, Set<String>> placeList) {
+    private static void sortPickupOrPlace(String theLocation, Map<String, Set<String>> placeList) {
         final String host = placeHost(theLocation);
         Set<String> l = placeList.computeIfAbsent(host, k -> new LinkedHashSet<>());
         if (l.contains(theLocation)) {

diff --git a/src/main/java/emissary/server/EmissaryServer.java b/src/main/java/emissary/server/EmissaryServer.java
@@ -557,7 +557,7 @@ private static ConstraintSecurityHandler buildSecurityHandler() {
         return handler;
     }
 
-    private LoginService buildLoginService() {
+    private static LoginService buildLoginService() {
         String jettyUsersFile = ConfigUtil.getConfigFile("jetty-users.properties");
         System.setProperty("emissary.jetty.users.file", jettyUsersFile); // for EmissaryClient
         return new HashLoginService("EmissaryRealm", jettyUsersFile);

diff --git a/src/main/java/emissary/server/mvc/adapters/DirectoryAdapter.java b/src/main/java/emissary/server/mvc/adapters/DirectoryAdapter.java
@@ -305,7 +305,7 @@ private static DirectoryEntryMap filterDirectoryEntryMap(DirectoryEntryMap map)
      *
      * @param name name of the local directory or null for default
      */
-    private IRemoteDirectory getLocalDirectory(final String name) {
+    private static IRemoteDirectory getLocalDirectory(final String name) {
         return new IRemoteDirectory.Lookup().getLocalDirectory(name);
     }
 }