Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move XMLCodec constants to new classes. #525

Closed
jdcove2 opened this issue Jul 27, 2023 · 0 comments
Closed

Move XMLCodec constants to new classes. #525

jdcove2 opened this issue Jul 27, 2023 · 0 comments
Assignees
@sambish5

Comments

@jdcove2
Copy link
Collaborator

jdcove2 commented Jul 27, 2023 

          We should consider moving the method name constants to an `emissary.core.constants.IBDOMethodNames` class and moving the element name constants to an `emissary.test.core.constants.AnswerFileElementNames` class.

Originally posted by @drivenflywheel in #515 (comment)
@sambish5 sambish5 self-assigned this Jul 31, 2023
@jpdahlke jpdahlke linked a pull request Aug 2, 2023 that will close this issue
RegressionTest updates. #515
Merged
@jpdahlke jpdahlke closed this as completed Aug 2, 2023
@sambish5 sambish5 reopened this Aug 2, 2023
@jpdahlke jpdahlke removed a link to a pull request Aug 2, 2023
RegressionTest updates. #515
Merged
@sambish5 sambish5 closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambish5 sambish5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpdahlke @sambish5 @jdcove2