Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegressionTest updates. #515

Merged
merged 2 commits into from
Aug 2, 2023
Merged

RegressionTest updates. #515

merged 2 commits into from
Aug 2, 2023

Conversation

jdcove2
Copy link
Collaborator

@jdcove2 jdcove2 commented Jul 7, 2023

This PR accomplishes the following:

  • RegressionTest basic behavior changed to sha256 hash IBDO non-printable data instead of base64'ing it.
  • Refactor encoders and decoders into their own class so they can be easily changed.

drivenflywheel
drivenflywheel requested changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small bit of additional cleanup suggested. This PR is a nice improvement, especially the default change to persist less obfuscated data into the answer files

src/test/java/emissary/test/core/junit5/RegressionTest.java Outdated Show resolved Hide resolved
src/main/java/emissary/core/IBaseDataObjectXmlCodecs.java Outdated Show resolved Hide resolved
src/main/java/emissary/core/IBaseDataObjectXmlCodecs.java Outdated Show resolved Hide resolved
src/main/java/emissary/core/IBaseDataObjectXmlCodecs.java Outdated Show resolved Hide resolved
src/main/java/emissary/core/IBaseDataObjectXmlCodecs.java Outdated Show resolved Hide resolved
src/main/java/emissary/core/IBaseDataObjectXmlCodecs.java Show resolved Hide resolved
src/main/java/emissary/core/IBaseDataObjectXmlHelper.java Show resolved Hide resolved
This was referenced Jul 27, 2023
Closed
Closed
drivenflywheel
drivenflywheel approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jpdahlke jpdahlke added this to the v8.0.0-M2 milestone Aug 1, 2023
@jpdahlke jpdahlke added the enhancement An enhancement or update to an existing feature label Aug 1, 2023
@jpdahlke jpdahlke merged commit 2f8c67b into NationalSecurityAgency:master Aug 2, 2023
9 checks passed
This was linked to issues Aug 2, 2023
Make the XmlCodec ElementDecoder instances private and leverage them through type-specific methods #524
Closed
Move XMLCodec constants to new classes. #525
Closed
This was unlinked from issues Aug 2, 2023
Make the XmlCodec ElementDecoder instances private and leverage them through type-specific methods #524
Closed
Move XMLCodec constants to new classes. #525
Closed
@sambish5 sambish5 mentioned this pull request Aug 4, 2023
Merged
aL118 pushed a commit to aL118/emissary that referenced this pull request Aug 4, 2023
@jdcove2 @aL118
RegressionTest updates. (NationalSecurityAgency#515)
c61445e
aL118 pushed a commit to aL118/emissary that referenced this pull request Aug 4, 2023
@jdcove2 @aL118
RegressionTest updates. (NationalSecurityAgency#515)
b5b927e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@sambish5 sambish5 sambish5 approved these changes

@fbruton fbruton Awaiting requested review from fbruton

Assignees
No one assigned
Labels
enhancement An enhancement or update to an existing feature
Projects
None yet
Milestone
v8.0.0-M2
Development

Successfully merging this pull request may close these issues.
4 participants
@jdcove2 @drivenflywheel @sambish5 @jpdahlke