Lift convertHexDate from MsSqlJflex into TimeUtil #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-mlb
requested changes
Jul 17, 2023
dev-mlb
approved these changes
Jul 18, 2023
dev-mlb
previously requested changes
Jul 20, 2023
drivenflywheel
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Should give TimeUtil its own Logger so we can maintain behavioral consistency with the original interface.
private static Logger logger = LoggerFactory.getLogger(TimeUtil.class);The "use constants" suggestions are purely optional, although I hate dragging around existing tech-debt
jpdahlke
approved these changes
Jul 28, 2023
aL118
added a commit
to aL118/emissary
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.