Sort parameters before diff in IBaseDataObjectDiffHelper #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdcove2
requested changes
Jul 27, 2023
|
@jdcove2 your suggestions were added. I didn't even think about the TreeMap auto sorting, so good point out to make it way simpler. Also added a test in to verify that the conversion to the TreeMap actually sorts. |
drivenflywheel
requested changes
Jul 28, 2023
jdcove2
approved these changes
Jul 31, 2023
aL118
pushed a commit
to aL118/emissary
that referenced
this pull request
Aug 4, 2023
aL118
pushed a commit
to aL118/emissary
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/NationalSecurityAgency/burrito-grande/issues/2325
Have the map of parameters be sorted before looking at differences between two IBDO's.