-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RELEASING.md document #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions. They can be dismissed with little impact.
Co-authored-by: drivenflywheel <dan@drivenflywheel.com>
Co-authored-by: drivenflywheel <dan@drivenflywheel.com>
Co-authored-by: drivenflywheel <dan@drivenflywheel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I know this was already merged, but these instructions didn't include any details about the preferred way the patch makes it into the master branch. Or was the idea that the change is made in master and then cherry picked into the patch branch? |
That is the preferred way. But no reason we can’t be explicit about it in the doc. I can add a section describing that later today and put up a PR |
No description provided.