Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RELEASING.md document #526

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

jpdahlke
Copy link
Collaborator

No description provided.

@jpdahlke jpdahlke added the documentation Updates to documentation only label Jul 28, 2023
@jpdahlke jpdahlke added this to the v8.0.0-M2 milestone Jul 28, 2023
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. They can be dismissed with little impact.

RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
jpdahlke and others added 3 commits August 2, 2023 11:37
Co-authored-by: drivenflywheel <dan@drivenflywheel.com>
Co-authored-by: drivenflywheel <dan@drivenflywheel.com>
Co-authored-by: drivenflywheel <dan@drivenflywheel.com>
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cfkoehler cfkoehler self-requested a review August 4, 2023 10:40
@cfkoehler cfkoehler merged commit e7e5d6c into NationalSecurityAgency:master Aug 8, 2023
9 checks passed
@ldhardy
Copy link
Collaborator

ldhardy commented Aug 9, 2023

I know this was already merged, but these instructions didn't include any details about the preferred way the patch makes it into the master branch. Or was the idea that the change is made in master and then cherry picked into the patch branch?

@cfkoehler
Copy link
Collaborator

I know this was already merged, but these instructions didn't include any details about the preferred way the patch makes it into the master branch. Or was the idea that the change is made in master and then cherry picked into the patch branch?

That is the preferred way. But no reason we can’t be explicit about it in the doc. I can add a section describing that later today and put up a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates to documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants