2361 - Added hadolint config and set failure threshold to 'error'. #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Super-Linter and actions/checkout do not natively handle pull requests from forks well so I added a check for whether or not the workflow was triggered by a pull request and, if so, ensures it first checks out the PR head and sets it locally to track the origin/master branch so when Super-Linter does it's built-in pull request everything lines up. |
cfkoehler
reviewed
Aug 17, 2023
jpdahlke
requested changes
Aug 24, 2023
jpdahlke
approved these changes
Sep 1, 2023
cfkoehler
approved these changes
Sep 1, 2023
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hadolint config, set failure threshold to "error", and added a check/run that checks out the forked repository head when triggered by a pull request to prevent the workflow trying to run in a detached head state (and thereby signalling a false pass).