Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new navigation #82

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Conversation

Patrick1904
Copy link
Contributor

@Patrick1904 Patrick1904 commented Dec 21, 2022

This PR replaces the current navigation with a new navigation. Figma design found here.

Logged out mobile
Screen Shot 2023-01-12 at 4 28 17 PM

Logged in mobile
Screen Shot 2023-01-12 at 4 29 52 PM

Logged out desktop
Screen Shot 2023-01-12 at 4 29 12 PM

Logged in desktop
Screen Shot 2023-01-12 at 4 31 19 PM

@evgenykuzyakov
Copy link
Contributor

Overall, this design is more fit for developers audience (assuming I understand Create button). Is it intended to be displayed on the different domain or by default for near.social?

  • It's missing storage balance withdrawal option in the dropdown
  • Create button has unclear purpose (maybe I miss the context, but does it show "fork"/"new" selection?).
  • Profile can be a single widget, don't need to split it into the name and image separately. See https://near.social/#/mob.near/widget/WidgetSource?src=mob.near/widget/Profile.ShortInlineBlock
  • Documentation and Editor are not needed for general audience, so should we enable them only for dev mode or separate domain?

@Patrick1904
Copy link
Contributor Author

Overall, this design is more fit for developers audience (assuming I understand Create button). Is it intended to be displayed on the different domain or by default for near.social?

  • It's missing storage balance withdrawal option in the dropdown
  • Create button has unclear purpose (maybe I miss the context, but does it show "fork"/"new" selection?).
  • Profile can be a single widget, don't need to split it into the name and image separately. See https://near.social/#/mob.near/widget/WidgetSource?src=mob.near/widget/Profile.ShortInlineBlock
  • Documentation and Editor are not needed for general audience, so should we enable them only for dev mode or separate domain?

Thanks @evgenykuzyakov. Since we're considering UX/UI - should we find a suitable placement for view source and fork? Seems that may also be better viewed in a 'dev' mode, etc.

Screen Shot 2022-12-22 at 11 21 57 AM

cc @heycorwin

@Patrick1904 Patrick1904 changed the title feat: Add necessary UI for desktop navigation feat: Add new navigation Jan 10, 2023
@Patrick1904 Patrick1904 marked this pull request as draft January 10, 2023 23:18
@Patrick1904 Patrick1904 marked this pull request as ready for review January 12, 2023 21:32
@evgenykuzyakov
Copy link
Contributor

  1. We should decrease top margin, since "View source" and "Fork" are under the hamburger now.

  2. Hide "Profile" link from the mobile menu when not signed in.

@Patrick1904
Copy link
Contributor Author

  1. We should decrease top margin, since "View source" and "Fork" are under the hamburger now.

I suggest we keep some white space but I decreased it from 120px to 100px.

  1. Hide "Profile" link from the mobile menu when not signed in.

I think it's preferable to let guest users know there is a profile, and where the button is located, but encourage the user to 'finish your profile by signing up' when they land on the empty profile page. WDYT?

@evgenykuzyakov
Copy link
Contributor

I think it's preferable to let guest users know there is a profile, and where the button is located, but encourage the user to 'finish your profile by signing up' when they land on the empty profile page. WDYT?

Let's disable this button, so it can't be clicked until you sign in.

@Patrick1904
Copy link
Contributor Author

I think it's preferable to let guest users know there is a profile, and where the button is located, but encourage the user to 'finish your profile by signing up' when they land on the empty profile page. WDYT?

Let's disable this button, so it can't be clicked until you sign in.

Disabled the 'profile' button when logged out:

Screen Shot 2023-01-12 at 5 20 16 PM

@Patrick1904 Patrick1904 merged commit 8ea1649 into NearSocial:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants