[pull] master from nylas:master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: We weren't changing into the directory of the git repository, so running the script from anywhere but inside the git repo didn't work. We also weren't pulling before checking for the latest commit. Now we do both of these things. Test Plan: Run locally Reviewers: spang, juan, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D4339
Test Plan: ran locally (need client secret for this) Reviewers: mark Reviewed By: mark Differential Revision: https://phab.nylas.com/D4343
Summary: See title Test Plan: Run locally Reviewers: juan, evan, spang Reviewed By: spang Differential Revision: https://phab.nylas.com/D4345
Makes the script like 4x faster.
Summary: Sometimes, when logging out of your NylasID and restarting the app, we would continue making some requests from the worker window that required a NylasID. This would make the app enter a restart loop and become completely unresponsive because when we made a request without a NylasID, we would force the user to log out and restart the app, and then we would again make the requests without the id, ad infinitum. To fix this, we make sure we have a NylasID before making any requests that require it Test Plan: manual Reviewers: halla, evan Reviewed By: halla, evan Differential Revision: https://phab.nylas.com/D4344
Summary: We should only count the initial enabling as a feature usage. This diff only changes send-later and send-reminders. Snooze is more complicated, since it's a thread-level action but the metadata is stored on the messages, and I'm probably just gonna punt it for now. Test Plan: manual Reviewers: evan, juan Reviewed By: evan, juan Differential Revision: https://phab.nylas.com/D4349
… for updates Summary: Previously, is you signed out of your NylasID, you would not pick up new updates because we never updated the autoupdater url to use the new id. Test Plan: manual Reviewers: mark, halla, evan Reviewed By: halla, evan Differential Revision: https://phab.nylas.com/D4346
Summary: Remove packages from the disabled package list when they have been migrated to be enabled by default. Also, the last migration would not have worked properly anyways because the daily channel was already on 1.0.56, and we check for greater-than rather than equal-to. Bump that version to match the next update. Test Plan: manual Reviewers: juan, evan Reviewed By: juan, evan Differential Revision: https://phab.nylas.com/D4335
Summary: The unapply transformation was incorrectly passing the props parameter to buildAnchorTag() as a string, even though it expects an object. buildAnchorTag() goes on to stringify this parameter, which causes extra surrounding quotations and escape slashes in front of all the other quotations. The unapply transform is applied on several re-renders, which causes the number of escape characters to unboundedly increase. Firstly, this was causing inline images to not appear properly in the draft, and secondly, the large number of escape characters was making the draft body large enough to make the app unresponsive. This generally wasn't an issue because the unapply transformation is only applied when there has been an apply transformation, and this is triggered by the SyncbackDraftTask. This task was previously only queued upon send, in which case the user never re-opens the draft. Now, enabling send-later on a draft will queue the task, and these issues appear if the user re-opens the draft for editing. This diff makes it so that the unapply transform passes in the props as an object, like the buildAnchorTag function expects. Test Plan: manual Reviewers: evan, juan Reviewed By: evan, juan Differential Revision: https://phab.nylas.com/D4348
Summary: Just renaming some stuff Test Plan: manual Reviewers: mark, spang, evan, halla Reviewed By: spang, evan, halla Differential Revision: https://phab.nylas.com/D4342
Summary: see title Test Plan: manual Reviewers: evan, halla Reviewed By: halla Differential Revision: https://phab.nylas.com/D4354
Summary: The SyncbackDraftTask doesn't currently do anything, so don't bother queuing it. Test Plan: manual Reviewers: evan, halla Reviewed By: evan Differential Revision: https://phab.nylas.com/D4352
Summary: There were 2 things wrong with the send later button: 1. We were not displaying the `saving` state correctly-- we only showed the button as saving for a brief moment while we called `authPlugin`, but we didn't show it for when we were creating the draft and uploading attachments to s3 which could take a long time. So if you had attachments and sent later, the composer just looked unresponsive for a very long time. 2. When clearing a send later date, we were unnecessarily re-creating the draft body and uploading attachments to s3, also making the app feel unresponsive. When clearing the send later date, the only thing we need to do is set `expiration` to null Test Plan: manual Reviewers: khamidou, halla, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D4356
Summary: see title Test Plan: manual Reviewers: mark, halla, spang, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D4357
Summary: see title Test Plan: manual Reviewers: halla, mark, spang, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D4358
Summary: See title Test Plan: manual Reviewers: evan, juan Reviewed By: evan, juan Differential Revision: https://phab.nylas.com/D4351
Summary: According to bunyan, https://github.com/trentm/node-bunyan, errors are treated special. They either need to be the first argument of a log, or they need to be attached to the special `err` (NOT `error`) key of the logger object. Test Plan: manual Reviewers: halla, juan, spang Reviewed By: halla, juan, spang Differential Revision: https://phab.nylas.com/D4337
Summary: Also remove unused underscore Test Plan: manual Reviewers: juan, spang, halla Reviewed By: spang, halla Differential Revision: https://phab.nylas.com/D4340
Summary: This removes the old SignalFX reporter that we weren't using Adding documentation around logging Test Plan: manual Reviewers: juan, halla, spang Reviewed By: juan, halla, spang Differential Revision: https://phab.nylas.com/D4341
Summary: This is a refactor of the workers to make it a bit more robust on cloud infrastructure. Since our tasks are crazy flaky, and the workers may be restarted at anytime, and there may be several workers running at once, this uses a new `CloudJob` table in the database to back every task that happens. Backing everything on the DB (not in Metadata) will hopefully make this substantially more robust to failing tasks, multiple workers across multiple processes and boxes, and easy to visualize the state of the workers' tasks Sorry for the HUGE diff, this was definitely a bit of a hurried effort to get this on staging today. Test Plan: Manual Reviewers: spang, khamidou, halla, juan Reviewed By: halla, juan Differential Revision: https://phab.nylas.com/D4355
Summary: When the sync worker got stuck inside `performSync`, we would never release the connection back to the connection pool. We would then try to start a new sync worker, and it would claim a new connection. If this happened enough times, we would eventually exhaust the whole pool and keep the sync worker blocked forever. Test Plan: manual Reviewers: evan, spang, halla, mark Reviewed By: halla, mark Differential Revision: https://phab.nylas.com/D4359
…one` Summary: Previously, calling the IMAPConnectionPool `onDone` callback when checking out a connection would just return the connection to the pool without re-establishing it the next time we checked it out of the pool. When the `onDone` callback was called in an error scenario, this had the unintended consequence of returning a bad connection to the pool, and then re-using this bad connection. The only scenario when the connection was re-established was if `onConnected` threw an error, but if the connection was kept open outside the scope of onConnected, this logic would never run. To make things simpler and more consistent, `onDone` will always destroy all connections and connections will always be re-established from scratch every time they are checked out of the pool. The pool acts more as a limit to the number of connections per account, than an actual shared pool of connections. Test Plan: manual Reviewers: evan, spang, halla, mark Reviewed By: halla, mark Differential Revision: https://phab.nylas.com/D4360
Summary: Make sure SyncActivity.getLastSyncActivityForAccount returns a sensible default to prevent runtime errors when the SyncProcessManager uses it Test Plan: manual Reviewers: evan, halla Reviewed By: halla Differential Revision: https://phab.nylas.com/D4366
Summary: It needs to be wrapped in an object. Test Plan: manual Reviewers: evan, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D4367
Summary: See title Test Plan: Run on the coffee machine Reviewers: juan, evan, spang Reviewed By: spang Differential Revision: https://phab.nylas.com/D4368
This is a squash of a bunch of commits releated to feature limiting. Includes making the upgrade path seamless by accessing billing through a WebView and making sure that the feature is enabled after upgrading, or canceled if the upgrade path is stopped by the user in any way. Included diffs --------------- Differential Revision: https://phab.nylas.com/D4078 Differential Revision: https://phab.nylas.com/D4136 Differential Revision: https://phab.nylas.com/D4137 Differential Revision: https://phab.nylas.com/D4143 Differential Revision: https://phab.nylas.com/D4147 Differential Revision: https://phab.nylas.com/D4171 Differential Revision: https://phab.nylas.com/D4173
Cleanup in preparation for open sourcing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )