Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

Check Timestamps & delete older then 24h #42

Closed
wants to merge 3 commits into from
Closed

Check Timestamps & delete older then 24h #42

wants to merge 3 commits into from

Conversation

HokoriXIII
Copy link
Contributor

@HokoriXIII HokoriXIII commented Sep 9, 2016

Short Description:

check Timestamps & delete older then 24h

Fixes (provide links to github issues if you can):

Bot keeps catching after 998 pokemons #37

  • Possible fix for Farm Pokemons&PokeStops more than limit

check Timestamps & delete older then 24h for PokemonCatch
check Timestamps & delete older then 24h for PokeStops
@HokoriXIII
Copy link
Contributor Author

HokoriXIII commented Sep 9, 2016

Not fixed yet.
Fixing.

check Timestamps & delete older then 24h on load
@HokoriXIII
Copy link
Contributor Author

HokoriXIII commented Sep 9, 2016

Fixed PokeStops&Pokemons count on load.
Working on ingamecount fix

@ghost ghost added the bug label Sep 9, 2016
@mo0ojava
Copy link
Contributor

mo0ojava commented Sep 9, 2016

I think that's only a partial fix. SearchThresholdExceeds in UseNearbyPokestopsTask is still messed up. As long as the RemoveRange remains in there, the list will be reset and the next time this part of the code gets iterated it's back to being run.

Not adding a commit since you're working on this, but cooked up a suggestion for SearchThresholdExceeds.
[edit - that wasn't working - back to the sketchboard]
[might as well have a static flag that gets triggered when PokeStopLimit and/or PokeStopLimitMinutes are reached]

@HokoriXIII
Copy link
Contributor Author

HokoriXIII commented Sep 9, 2016

specifically generated file timestamp.
the first two tests were normal, the third already started using pokestop file itself was cleaned almost 2/3

Sorry for bad English, it`s not native. @mo0ojava You can do your commit


[17:42:01] You are visiting pokestops too fast. Your cannot visit another one until 34311 seconds later
[17:42:14] You are visiting pokestops too fast. Your cannot visit another one until 34358 seconds later
[17:42:48] Name: Karavayev V.O. XP: 50, Gems: 0, Items: 2 x ItemPokeBall, 1 x ItemRevive, Lat: 50.442889, Long: 30.515358, Alt: 175.95497585831

@mo0ojava
Copy link
Contributor

mo0ojava commented Sep 9, 2016

Wont finish it in time, have to get going. :(
This part returns true for FarmPokestop to break; But that's not enough it seems. The bot keeps on looting Pokestops anyway. Have to dig a bit more in this apparently.
SearchThresholdExceeds.txt

@mo0ojava
Copy link
Contributor

Got a fix working yesterday. Have to merge it in manually it seems. Perhaps later today when back home.

@mo0ojava
Copy link
Contributor

Just a funny sidenote. The cancellationToken system were in quite some disrepair. Bet that haven't been working for quite some time. This fix relies on that system though so changing that part a bit as well.

@hardknoxni69a
Copy link
Contributor

OMG has this finally been implemented rotating 24hour clock so as soon as the 24 hours is up it will delete entry 1 by 1 as clock continues?

@mo0ojava
Copy link
Contributor

Fixed in #37.
See description there.

@mo0ojava mo0ojava closed this Sep 10, 2016
@ghost ghost added the enhancement label Sep 12, 2016
@ghost ghost changed the title check Timestamps & delete older then 24h Check Timestamps & delete older then 24h Sep 12, 2016
@ghost ghost added bug and removed bug enhancement labels Sep 12, 2016
samuraitruong pushed a commit that referenced this pull request Feb 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants