Replace multiple calls to precision(::AbsMSeries) #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is type unstable, so at least internal code is better off not calling it
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 86.81% 86.81% -0.01%
==========================================
Files 110 110
Lines 28649 28648 -1
==========================================
- Hits 24873 24872 -1
Misses 3776 3776
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Is this related to the refactoring or independent? |
|
I am not even sure which refactoring you refer to, so I am guessing "unrelated" :-). I.e., this is just about fixing an issue reported by JET, and then extending it some more. But if somebody is planning to refactor this code to not do weird type unstable things, I'd be happy to close this PR in favor of that! |
|
I think I meant the changed constructor, but I see. |
fingolfin
added a commit
to mgkurtz/AbstractAlgebra.jl
that referenced
this pull request
Nov 21, 2023
This function is type unstable, so at least internal code is better off not calling it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is type unstable, so at least internal code is better off not calling it.
See also this discussion.