Move stuff from Oscar to AbstractAlgebra #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `@attributes` mutable struct MPolyRing - generic `iszero` for ideals - Dan's code for gcd, factor for nested polynomial rings
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
- Coverage 86.86% 86.73% -0.13%
==========================================
Files 110 111 +1
Lines 28664 28828 +164
==========================================
+ Hits 24900 25005 +105
- Misses 3764 3823 +59
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Hm, whats up with the doctest? |
I am not sure what that refers to? All doctests seem to pass? Or maybe something was broken and you restarted it and I only saw the fixed result? |
|
Ah. That doctest failure is caused by Singular.jl changes. I've changed the Singular.jl version in the repo to 0.19.0-DEV now to avoid this. |
fingolfin
added a commit
to mgkurtz/AbstractAlgebra.jl
that referenced
this pull request
Nov 21, 2023
- add `@attributes` mutable struct MPolyRing - generic `iszero` for ideals - Dan's code for gcd, factor for nested polynomial rings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@attributesmutable struct MPolyRingiszerofor ideals