-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add divexact!, lcm!, submul! #1812
Conversation
Also refactor the code defining them to use macros to reduce repetition substantially. Finally merge and update the sections discussion unsafe operators in the "rings" and "ring interface" chapters of the manual: the latter now
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1812 +/- ##
==========================================
+ Coverage 88.03% 88.04% +0.01%
==========================================
Files 119 119
Lines 30057 30045 -12
==========================================
- Hits 26460 26454 -6
+ Misses 3597 3591 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the comments, fine with me. I am not a big fan of @eval
for these small loops, but we can of course unroll them again later, if we want to change only one of them
Comments addressed. I don't love The current setup also makes it super easy to add more of these... e.g. |
Can you add HeckeCI, NemoCI and SingularCI to the "required" list? I am afraid to use auto-merge otherwise as it could just ignore those CI results. |
Also refactor the code defining them to use macros to reduce
repetition substantially.
Finally merge and update the sections discussion unsafe operators
in the "rings" and "ring interface" chapters of the manual: the latter
now